fix: fix wind and water mappings for Q7 (#715) #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the wind and water mappings for the Roborock Q7 (B01) device by correcting the numeric values in the enum mappings. The changes shift enum values to start from 1 instead of 0, matching the actual API values returned by the device.
Key changes:
- Updated
SCWindMappingenum values (shifted from 0-3 to 1-4, added new value 5 for SUPER_STRONG_PLUS) - Updated
WaterLevelMappingenum values (shifted from 0-2 to 1-3) - Updated corresponding test cases to reflect the new mapping values
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
roborock/data/b01_q7/b01_q7_code_mappings.py |
Updated SCWindMapping and WaterLevelMapping enum values to match actual device API responses |
tests/devices/traits/b01/q7/test_init.py |
Updated test data and comments to use correct wind value (2 for STANDARD) |
tests/data/b01_q7/test_b01_q7_containers.py |
Updated assertion to expect STRONG instead of SUPER_STRONG for wind value 3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenporter
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#715 was targeted not on main. Cherry picked for here.